-
Notifications
You must be signed in to change notification settings - Fork 7
Add a supercell case for model validation #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We could increase the threshold, but this suggests the embedded images are large, maybe we can reduce the resolution? An alternative is to try again |
|
Oh, another alternative is to display the PNG images saved to disk, i.e. replace things like save("supercell_warm_bubble.png", fig) #src
figwith save("supercell_warm_bubble.png", fig)
# But again, the other PNG images we have seem to be a lot smaller. |
The simulation is run in single precision.
|
Does anyone happen to know why one of the checks has been pending for hours? |
|
It's not pending, it's a github UI glitch: it's a "required" check, but this PR only touches documentation and we don't run the tests jobs in that case to save resources, so they will never run anyway. The github UI shows the check as "pending" because they don't seem to have a concept of a job which is "required to pass when it runs, but could be skipped", for them "required" is always required to even run. |
Got it. In this case, how do we merge the PR? Use the command line? |
|
If this is good to go (it is from my point of view, I don't know if @glwagner has more comments), we can bypass the required check |
|
unfortunately the preview has expired (and there are conflicts) --- once these are fixed, i would love to see the preview |
glwagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made only minor notational comments. Once these are addressed I'm happy to see this merged.
Co-authored-by: Gregory L. Wagner <gregory.leclaire.wagner@gmail.com>
Co-authored-by: Gregory L. Wagner <gregory.leclaire.wagner@gmail.com>
Co-authored-by: Gregory L. Wagner <gregory.leclaire.wagner@gmail.com>
When this happens, if you rerun the last "deploy-docs" (not the build one) job the preview should reappear in a couple of minutes. |
|
@giordano I think this one is ready to be merged. I don’t see a bypass option on my end. Could you go ahead and merge it? |


This PR adds a splitting supercell case following the DCMIP2016 protocol. The case provides a standardized, well-documented benchmark for validating dynamical core behavior in a deep, moist convective regime.